Skip to content

Allow duplicate names in different modbus entities#112701

Merged
janiversen merged 1 commit into
home-assistant:devfrom
janiversen:solve_112645
Mar 8, 2024
Merged

Allow duplicate names in different modbus entities#112701
janiversen merged 1 commit into
home-assistant:devfrom
janiversen:solve_112645

Conversation

@janiversen
Copy link
Copy Markdown
Member

Breaking change

Proposed change

Modbus integration checks for duplicate entity names, which avoids problems, however duplicates are only within
the same entity, e.g.

    sensor.entity1
    binary_sensor.entity1

Is not a duplicate and should be allowed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@janiversen janiversen merged commit ea89fa6 into home-assistant:dev Mar 8, 2024
@janiversen janiversen deleted the solve_112645 branch March 8, 2024 14:11
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modbus entity duplicate even is thay are a different type

3 participants